x-ing out Annotation Layer type makes the page blank

[benceorlai]

Expected results

Layer type resets to default

Actual results

The entire page goes blank

Screenshots

How to reproduce the bug

1. Open a Chart in Explore
2. Click + Add Annotation Layer
3. Click on the little x next to Formula in the ANNOTATION LAYER TYPE
4. See the whole page go blank

Environment

(please complete the following information):

• superset version: master sha 676e0bb
• python version:
• node.js version:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

[junlincc]

Expected behavior: user click x to exit annotation modal and go back to explore

we should just kill the xs in the drop down menus as they are really not needed.. appreciate anyone who can throw a quick fix.

[nytai]

We should also handle the fact that the explore page goes completely blank when there's an error. I think we just need to wrap the explore page in an ErrorBoundary

[benceorlai]

at the risk of nitpicking, i think the expected behavior of that x is to reset the value of the dropdown to its default, not to close out the popover. the real issue though is the page blankout, which I think is quite serious (although an edge case)

[junlincc]

i think the expected behavior of that x is to reset the value of the dropdown to its default, not to close out the popover.

closing the modal is what the other Xs do in the same modal currently.

[mistercrunch]

It's also possible/easy to remove the x by setting the prop clearable: false