Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Lab UI cosmetic issues - buttons overlap when scrolling, results area doesn't adjust size #12046

Closed
2 of 3 tasks
zuzana-vej opened this issue Dec 14, 2020 · 5 comments
Closed
2 of 3 tasks
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed P1 Priority item - Major sqllab:control:ui

Comments

@zuzana-vej
Copy link
Contributor

Few small UI cosmetic issues on SQL Lab:

  1. When you scroll all the way down, buttons overlap with results.
    image (3)
    video:
    SQLLab-UI

  2. Some users reported that sometimes the buttons completely disappear.
    image (5)

  3. There are 3 scroll bars on the right hand side (seems unnecessary)
    image (4)

  4. The results area doesn't adjust size - in this example, which has only 2 result columns which are both very short, it still display scroller at the bottom. At the same time, when resized to larger monitor, there is lot of white space (this is less annoying than the scroller then there are 2 columns as result)
    Screen Shot 2020-12-14 at 2 55 06 PM

Screen Shot 2020-12-14 at 2 54 54 PM

How to reproduce the bug

  1. Go to 'SQL Lab'
  2. Run a query which will return larger number of rows than what would fit on the scree
  3. Scroll down to see the various issues
  4. Resize your screen (try laptop size / monitor size / half laptop size)

Environment

  • superset version: couple days behind master
  • python version: python --version
  • node.js version: node -v

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Couple days behind master, but as per recently merged PRs, haven't noticed any addressing these.

@zuzana-vej zuzana-vej added !deprecated-label:bug Deprecated label - Use #bug instead #bug:cosmetic Cosmetic/layout/design tweak needed sqllab Namespace | Anything related to the SQL Lab labels Dec 14, 2020
@zuzana-vej
Copy link
Contributor Author

zuzana-vej commented Dec 14, 2020

I think the overlapping / disappearing buttons should get resolved. Rest of the items are things I noticed when trying to repro the issue with buttons, and wanted to include them, but they are nice to have in my opinion.

Browser details: Google Chrome latest version (Version 87.0.4280.88)

@yousoph
Copy link
Member

yousoph commented Dec 15, 2020

Thanks for reporting! We will take a look. Haven't been able to repro the disappearing buttons yet but agreed overlap/disappearing buttons need to be fixed.

@junlincc
Copy link
Member

@rusackas could it relate to any recent refactoring work we did?

@hughhhh
Copy link
Member

hughhhh commented Dec 21, 2020

@eschutho is working on this currently

@junlincc junlincc added sqllab:control:ui and removed sqllab Namespace | Anything related to the SQL Lab !deprecated-label:bug Deprecated label - Use #bug instead labels Jan 3, 2021
@zuzana-vej zuzana-vej added the P1 Priority item - Major label Jan 6, 2021
@ktmud
Copy link
Member

ktmud commented Jan 13, 2021

Closed by #12318

@ktmud ktmud closed this as completed Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed P1 Priority item - Major sqllab:control:ui
Projects
None yet
Development

No branches or pull requests

5 participants