Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explore] datapanel search should not case sensitive #12299

Closed
graceguo-supercat opened this issue Jan 6, 2021 · 5 comments
Closed

[explore] datapanel search should not case sensitive #12299

graceguo-supercat opened this issue Jan 6, 2021 · 5 comments
Labels
assigned:preset Assigned to the Preset team explore:datapanel Related to the Data panel of Explore P1 Priority item - Major

Comments

@graceguo-supercat
Copy link

Screenshots

fnLVBHBoVP

How to reproduce the bug

  1. Go to explore view, search "SUM" in datapanel
  2. found no match
  3. search "sum", you will find some results

Environment

latest master

cc @junlincc @zuzana-vej
@graceguo-supercat graceguo-supercat added the explore:datapanel Related to the Data panel of Explore label Jan 6, 2021
@issue-label-bot issue-label-bot bot added the #bug Bug report label Jan 6, 2021
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.96. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@graceguo-supercat graceguo-supercat added the P1 Priority item - Major label Jan 6, 2021
@junlincc junlincc removed the #bug Bug report label Jan 6, 2021
@ktmud
Copy link
Member

ktmud commented Jan 6, 2021

I'd recommend utilize match-sorter for things like this.

E.g.

https://github.com/apache-superset/superset-ui/blob/a4ecdb3d5a7791e864703318d6da9154bb842762/plugins/plugin-chart-table/src/DataTable/DataTable.tsx#L120-L123

@junlincc
Copy link
Member

junlincc commented Jan 6, 2021 •
edited
Loading

I'd recommend utilize match-sorter for things like this.

E.g.

https://github.com/apache-superset/superset-ui/blob/a4ecdb3d5a7791e864703318d6da9154bb842762/plugins/plugin-chart-table/src/DataTable/DataTable.tsx#L120-L123

Thanks ^
we have the metric section search not case sensitive actually...
agree they should be the same, will change it real quick~

@junlincc junlincc added the assigned:preset Assigned to the Preset team label Jan 6, 2021
This was referenced Jan 6, 2021
Closed
Closed
@pkdotson pkdotson mentioned this issue Jan 7, 2021
Merged
5 tasks
@graceguo-supercat
Copy link
Author

we have the metric section search not case sensitive actually...
agree they should be the same, will change it real quick~

in my screenshot you will see i am searching metrics name, and it is case sensitive right now.

@junlincc
Copy link
Member

junlincc commented Jan 7, 2021

resolved, closing. thanks @pkdotson 🙏

@junlincc junlincc closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned:preset Assigned to the Preset team explore:datapanel Related to the Data panel of Explore P1 Priority item - Major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ktmud @graceguo-supercat @junlincc