[dashboard] including chart which is malformed (removed datasource) results in broken links

[adam-stasiak]

When I open chart which is malformed because of deleted datasource I get error.

Expected results

?? @benceorlai Could you define what is expected behavior for such case? In additional context section I described problem.

Actual results

fatal error

Screenshots

How to reproduce the bug

Find chart with datasource X
Find dashboard with this chart
Remove datasource X
Open dashboard with this chart
See error

Environment

docker commit e47350e

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• [x ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
• [x ] I have reproduced the issue with at least the latest released version of superset.
• [x ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

You can find similiar issue #12475 resolved in PR #12468 . But here situation is more difficult because I can imagine situation where dashboard is full of valid charts and only single one is malformed and then user cannot access this space. We should think about long term solution for this - consistent for both cases.

CC: @junlincc @kkucharc

[nytai]

I updated the title because this is really an issue with the dashboard itself, not the list view. The same error would happen if the user were visiting a bookmarked link to the dashboard.

We should probably handle this the same way we're handling #12464 as it's just another symptom of the same problem.

[rusackas]

@adam-stasiak is there any reason to keep this Issue open?

[adam-stasiak]

we can close