Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dataset header floats on top of table entries #12541

Closed
villebro opened this issue Jan 15, 2021 · 2 comments
Closed

Change dataset header floats on top of table entries #12541

villebro opened this issue Jan 15, 2021 · 2 comments
Assignees
Labels
explore:dataset Related to the dataset of Explore explore:design Related to the Explore UI/UX

Comments

@villebro
Copy link
Member

Screenshot

change_dataset

Description

When scrolling the change dataset table, the header floats above the table entries. Regression caused by #12432

Design input

[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label design:review. If this includes a design proposal,
include the label design:suggest]

@villebro villebro added explore:design Related to the Explore UI/UX explore:dataset Related to the dataset of Explore labels Jan 15, 2021
@junlincc
Copy link
Member

junlincc commented Jan 15, 2021

Screen.Recording.2021-01-15.at.12.51.27.AM.mov

this behavior is currently not in master and is mentioned in #12503 but yea it would have caused regression without changes made in #12471 going in, thus not including both in v1.0. 🤦🏾‍♀️

@junlincc junlincc self-assigned this Jan 15, 2021
@villebro
Copy link
Member Author

Closing as this recording does not reflect current state of master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explore:dataset Related to the dataset of Explore explore:design Related to the Explore UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants