Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superset UI is doesn't escape / quote the search query and currently is not working with special characters #13708

Closed
3 tasks done
bkyryliuk opened this issue Mar 19, 2021 · 4 comments
Labels
#bug Bug report

Comments

@bkyryliuk
Copy link
Member

A clear and concise description of what the bug is.

Expected results

Superset UI e.g. should escape query search parameter for superset objects like charts, dashboards etc
Expected api call:
/api/v1/report/related/dashboard?q=(filter:%27[query]%27,page_size:2000)
image

Actual API call:
https://superset.pp.dropbox.com/api/v1/report/related/dashboard?q=(filter:[query],page_size:2000)

image

How to reproduce the bug

  1. open superset search
  2. search for [query]

Environment

https://github.com/airbnb/superset-fork/tree/release--2021-03-10

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

cc @dpgaspar , @villebro

@bkyryliuk bkyryliuk added the #bug Bug report label Mar 19, 2021
@nytai
Copy link
Member

nytai commented Mar 19, 2021

This seems like a rison encoding as all calls should be going through rison.encode, we may have to fork and make updates to that lib

@stale
Copy link

stale bot commented May 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label May 2, 2022
@rusackas
Copy link
Member

rusackas commented Jan 9, 2023

@bkyryliuk is this still an issue?

@stale stale bot removed the inactive Inactive for >= 30 days label Jan 9, 2023
@rusackas
Copy link
Member

Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please re-open this issue, open a new Issue with updated context, or raise a PR to address the problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

3 participants