Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Issue: additionalRequirements not working as expected #14188

Closed
kompetenzlandkarte opened this issue Apr 16, 2021 · 3 comments
Closed

Helm Issue: additionalRequirements not working as expected #14188

kompetenzlandkarte opened this issue Apr 16, 2021 · 3 comments
Labels
#bug Bug report

Comments

@kompetenzlandkarte
Copy link

I am trying to install superset on my kubernetes cluster. Hence I tried to install it via the helm chart. Also I want to use the vertica driver. So I specified the additionalRequirements property in the values.yml. Looking like this:

additionalRequirements:
  - sqlalchemy-vertica-python

#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#    http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

# Default values for superset.
# This is a YAML-formatted file.
# Declare variables to be passed into your templates
...

Expected results

When I specify additionalRequirements the additional requirements get installed.

Actual results

When I add the connection string like:

vertica+vertica_python://...

I get the error: ERROR: Could not load database driver: VerticaEngineSpec

Screenshots

N/A

How to reproduce the bug

see above

Environment

(please complete the following information):

  • superset version: Version: 0.999.0dev
  • python version: v3.7.9
  • node.js version: node -v
@kompetenzlandkarte kompetenzlandkarte added the #bug Bug report label Apr 16, 2021
@kompetenzlandkarte
Copy link
Author

Using the 1.1.0 Tag instead of latest solved the issue for me.

@Yann-J
Copy link
Contributor

Yann-J commented May 4, 2021

Just discovered this as well, it looks like this PR broke my deployment: #13917

The additionalRequirements was moved to a startup script in bootstrapScript...

@xasx
Copy link
Contributor

xasx commented Aug 23, 2021

This bug is still on master, thus in the latest version of the chart.

I propose reopening this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

3 participants