Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native-filters] interacting w native filter sidebar should not change dashboard ownership #15125

Closed
rosemarie-chiu opened this issue Jun 11, 2021 · 3 comments · Fixed by #15146
Assignees
Labels
#bug Bug report dashboard:native-filters Related to the native filters of the Dashboard P1 Priority item - Major

Comments

@rosemarie-chiu
Copy link
Contributor

Simply expand / retract native filter sidebar should not make you the owner of the dashboard

Steps

  1. Observe that you are not the owner of the dashboard in test
  2. Open the dashboard
  3. Expand and retract native filter
  4. Return to dashboard list

Expected results

There should be no ownership change on the dashboard

Actual results

I became the owner of the dashboard

CleanShot.2021-06-11.at.14.47.54.mp4
@rosemarie-chiu rosemarie-chiu added the #bug Bug report label Jun 11, 2021
@junlincc junlincc changed the title [native filter] Simply expand / retract native filter sidebar should not make you the owner of the dashboard [native-filters] interacting w native filter sidebar should not change dashboard ownership Jun 11, 2021
@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Jun 11, 2021
@junlincc junlincc added the P1 Priority item - Major label Jun 11, 2021
@villebro
Copy link
Member

It appears ownership is added when the dashboard is opened, so this isn't directly related to expanding/collapsing the filter tab.

@villebro
Copy link
Member

This happens even without the native filter feature flag being enabled, so removing the native filter tag.

@villebro villebro removed the dashboard:native-filters Related to the native filters of the Dashboard label Jun 14, 2021
@villebro
Copy link
Member

Re-adding the label and issue to the native filter board due to the problem being related to a native filter feature PR (apologies for the label/project board flip-flop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report dashboard:native-filters Related to the native filters of the Dashboard P1 Priority item - Major
Projects
None yet
4 participants