Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[annotation] table event annotation is broken after recent superset-ui upgrade #16708

Closed
3 tasks done
graceguo-supercat opened this issue Sep 14, 2021 · 4 comments
Closed
3 tasks done

[annotation] table event annotation is broken after recent superset-ui upgrade #16708

graceguo-supercat opened this issue Sep 14, 2021 · 4 comments
Assignees
@graceguo-supercat
Labels
#bug:cant-reproduce Bugs that cannot be reproduced #bug:regression Bugs that are identified as regessions #bug Bug report

Comments

@graceguo-supercat
Copy link

graceguo-supercat commented Sep 14, 2021 •
edited
Loading

Actual results

Table type Event Annotation didn't show on chart any more after #16601.

Screenshots

Screen_Shot_2021-09-14_at_4_35_48_PM

Environment

latest master.

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

cc @villebro
@graceguo-supercat graceguo-supercat added #bug:regression Bugs that are identified as regessions #bug Bug report labels Sep 14, 2021
@junlincc junlincc added the P1 Priority item - Major label Sep 15, 2021
@junlincc
Copy link
Member

@pkdotson may not be that straightforward but let's give it a try/ higher priority

@pkdotson
Copy link
Member

@graceguo-supercat can you please add steps to reproduce this with an example chart or add some steps to help our qa pinpoint this. I'm not able to reproduce this easily as the annotation does show on chart.

@junlincc junlincc added #bug:cant-reproduce Bugs that cannot be reproduced and removed P1 Priority item - Major labels Oct 12, 2021
@junlincc
Copy link
Member

@graceguo-supercat ^

@yousoph
Copy link
Member

yousoph commented Apr 6, 2022

Haven't been able to repro this either, please reopen with more details if you are still able to repro. Thanks!!

@yousoph yousoph closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graceguo-supercat graceguo-supercat

Labels
#bug:cant-reproduce Bugs that cannot be reproduced #bug:regression Bugs that are identified as regessions #bug Bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yousoph @pkdotson @graceguo-supercat @junlincc