Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default #17328

Closed
suddjian opened this issue Nov 2, 2021 · 4 comments
Closed

Comments

@suddjian
Copy link
Member

suddjian commented Nov 2, 2021

Should we apply and remove the DASHBOARD_NATIVE_FILTER flag in Superset 2.0? Or maybe we should keep the flag but just turn it on by default?

What's required:

  • A filter box migration script
  • Sufficiently high feature quality (I'm not sure what current status is here, maybe someone can catch me up)

Do we want to apply the same treatment to the other related feature flags too? What additional prep might be necessary for them?

@suddjian suddjian changed the title SIP-74 sub-proposal: Migrate DASHBOARD_NATIVE_FILTERS feature flag SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default Nov 2, 2021
@tweinreich
Copy link

I think it would be great if features like DASHBOARD_NATIVE_FILTER would be enabled by default but still exist as flags (or admin menu options) to turn them off. In my opinion the experience of creating filters is much easier compared to using the filter box chart widget and jinja templating.

@junlincc
Copy link
Member

we already turned said feature flag on by default 😅 and had a discussion to keep the FF until re reach 120% feature parity, which is current missing some complex use case of multiple filter boxes being a group of filters that limit filter value of each other. filter box code and the FF will both be removed after that.

@suddjian
Copy link
Member Author

suddjian commented Nov 19, 2021

@junlincc If that work gets done before SIP-74 is finalized (which might be quite a while), then removing the flag would be a good addition. Otherwise it would be best left for a later major release.

Are there any issues or trackable things for that functionality, that we can link to from this issue? Linking to it from here will make it easier to do 2.0 planning.

@suddjian suddjian reopened this Nov 19, 2021
@suddjian
Copy link
Member Author

This was done apparently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants