Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add db_engine_specs/risingwave.py to support time grain #22122

Closed
BowenXiao1999 opened this issue Nov 15, 2022 · 0 comments · Fixed by #22123
Closed

feat: add db_engine_specs/risingwave.py to support time grain #22122

BowenXiao1999 opened this issue Nov 15, 2022 · 0 comments · Fixed by #22123

Comments

@BowenXiao1999
Copy link
Contributor

BowenXiao1999 commented Nov 15, 2022

Hi, represents RisingWave. Want to add RisingWave into Superset's codebase for time grain support. RisingWave is a postgresql-compatitable database with sqlalchemy dialect. The driver is in here: https://github.com/risingwavelabs/sqlalchemy-risingwave.

I may need to add a db_engine_specs/risingwave.py. For the first version, I think highly alike db_engine_specs/cockroachdb.py.
I tried locally, only after add this file, the time grain option is going to work. (PS: Although we support postgresql protocol, the connection URI string is risingwave://.... instead of postgresql://...)

This issue is created before the PR. Glad to see your comments! Thanks.

@BowenXiao1999 BowenXiao1999 changed the title feat: add RisingWave Support feat: add db_engine_specs/risingwave.py to support time grain Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant