Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk select for filters #23315

Closed
ASchmidtGit opened this issue Mar 9, 2023 · 12 comments · Fixed by #23869
Closed

Bulk select for filters #23315

ASchmidtGit opened this issue Mar 9, 2023 · 12 comments · Fixed by #23869

Comments

@ASchmidtGit
Copy link

ASchmidtGit commented Mar 9, 2023

Heyho, is it possible to bulk select / select all values in a filter?
E.g. in my filter for article numbers i type "art-25116", so the filter shows all article numbers starting with "art-50876".
From this point i want to either select all or multiple values but as soon as i click on one the filter resets.

Edit: I selected "Can select multiple values" but this only allows multiple values to be selected but not selected at once

Current behavior:
NoBulkSelect

Behavior i want (gif made from sellerboard):
BulkSelect

@Govindarajan-D
Copy link
Contributor

Hi. I am able to do multiselect in the same dropdown instance. I took the most recent build from the website.
MultipleSelectSuperset

@ASchmidtGit
Copy link
Author

Because you dont search for a value in the filter first.
If i just open the filter dropdown and click on the first items shown i can select multiple items too without the list being resetted.

@Govindarajan-D
Copy link
Contributor

Ok got it. Let me check what I can do for that!

@Govindarajan-D
Copy link
Contributor

Hi. I made the change on my local and it works good. When we search and select, the search term doesn't get cleared. But one thing though, after I make selections, if I click on the input box, the search term vanishes and if I select outside, the search term gets added as a new filter.

You can watch the entire gif to see what I am speaking about. Would this be correct behaviour?

MultipleSelectSuperset

@ASchmidtGit
Copy link
Author

@Govindarajan-D Yes, that looks exactly like the behavior im looking for

@Govindarajan-D
Copy link
Contributor

Let me do more testing to see if everything is ok and create pull request for it

@ASchmidtGit
Copy link
Author

Awesome, thank you so much :D

@Govindarajan-D
Copy link
Contributor

@michael-s-molina With respect to this issue, I tried using autoClearSearchValue = false in SelectFilterPlugin.tsx. Previously it worked and I was able to test it and it was fine. But after some new commits, I am not able to make it work again using this. Can you help me on this? Thanks!

@michael-s-molina
Copy link
Member

@michael-s-molina With respect to this issue, I tried using autoClearSearchValue = false in SelectFilterPlugin.tsx. Previously it worked and I was able to test it and it was fine. But after some new commits, I am not able to make it work again using this. Can you help me on this? Thanks!

Sure. Do you have a PR with your changes?

@Govindarajan-D
Copy link
Contributor

No. Actually, I was making changes in my local, but since it didn't work I didn't push it yet. Shall I push the changes?

@michael-s-molina
Copy link
Member

@michael-s-molina With respect to this issue, I tried using autoClearSearchValue = false in SelectFilterPlugin.tsx. Previously it worked and I was able to test it and it was fine. But after some new commits, I am not able to make it work again using this. Can you help me on this? Thanks!

@Govindarajan-D autoClearSearchValue should be applied to the Select component instead of SelectFilterPlugin. Here's a PR to implement the requested feature.

@Govindarajan-D
Copy link
Contributor

Thanks @michael-s-molina for working on this! I was stuck for few days on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants