Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy Sunburst chart not rendering when secondary_metrics is null in 3.0.0rc3 #25154

Closed
3 tasks done
zhaorui2022 opened this issue Aug 31, 2023 · 1 comment · Fixed by #25159
Closed
3 tasks done

Legacy Sunburst chart not rendering when secondary_metrics is null in 3.0.0rc3 #25154

zhaorui2022 opened this issue Aug 31, 2023 · 1 comment · Fixed by #25159
Assignees

Comments

@zhaorui2022
Copy link
Contributor

While going through some legacy charts already exist in database. Sunburst charts no longer render in 3.0.0rc3, while it's working in 2.0.0.

How to reproduce the bug

I have tried to create a new sunburst chart but it seems the form data doesn't contain secondary_metrics with null as the value any more. However, we do have existing charts in production database contains such fields. In order to reproduce, we need to manually modify the chart from the backend db and add a null value for secondary_metrics.

  1. Create a sunburst chart
  2. Modify the chart from backend db and inject null as value for secondary_metrics.
  3. Refresh chart
  4. See error

Expected results

Sunburst chart renders as what it does in 2.0.0

Actual results

Chart complains about the null value and fails to render

Screenshots

In 3.0.0rc3
3 0 0rc3

In 2.0.0
2 0 0

Environment

(please complete the following information):

  • browser type and version: Chrome latest stable release
  • superset version: superset version 3.0.0rc2
  • python version: python --version 3.9
  • node.js version: node -v N/A
  • any feature flags active: I don't find any related feature flags

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@zhaorui2022
Copy link
Contributor Author

zhaorui2022 commented Aug 31, 2023

I just took another look at the broken ones, they seemed to be created 1 or 2 yrs ago. So maybe the secondary_metrics field was there in an older version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants