Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar chart with time delay displayed with the same color #26041

Open
martin-raymond opened this issue Nov 20, 2023 · 14 comments
Open

Bar chart with time delay displayed with the same color #26041

martin-raymond opened this issue Nov 20, 2023 · 14 comments
Assignees

Comments

@martin-raymond
Copy link
Contributor

Before the 3.0.1 :
image

After the 3.0.1 :
image

How to reproduce the bug

  1. Create a bar chart
  2. Add a time delay to visualize a comparison between the bar (a year, a month, it does not matter)
  3. Before the 3.0.1, each couple of bar had two colors, now they are all in the same color

Environment

  • superset version: 3.0.1
@martin-raymond martin-raymond changed the title Bar chart with time delay displays with the same color Bar chart with time delay displayed with the same color Nov 20, 2023
@sfirke
Copy link
Member

sfirke commented Nov 20, 2023

When you say "before 3.0.1" do you mean 3.0.0 did not have this problem? What's the latest official release you've found that has the prior, desired behavior?

@martin-raymond
Copy link
Contributor Author

martin-raymond commented Nov 20, 2023

we were using the 2.1.0 version, and now we have upgraded to 3.0.1 @sfirke

@michael-s-molina
Copy link
Member

michael-s-molina commented Nov 21, 2023

This was a side-effect of another fix. They should have the same color but we need to add a differentiator between normal and offset bars similar to what the line chart does by using dashed lines. I can take a look at this problem.

@michael-s-molina michael-s-molina self-assigned this Nov 21, 2023
@CairoLee
Copy link

CairoLee commented Jan 24, 2024

I also have the same question. For line charts, using dashed lines to differentiate offset lines for the same indicator is possible. But for bar charts, I think maintaining the previous logic might seem more reasonable.


I prefer to have them display different colors, especially when we are only drawing a single indicator and want to compare the data from a week ago. Showing different colors would be very convenient for observation.

But when we are drawing multiple indicators and want to compare the data from a week ago for all of them, using the same color but different styles should be more convenient for observation.

@jack-chao-htg
Copy link

In line charts, it makes the time-delay lines dotted instead of solid but in the same color. This is pretty nice, however, if you have multiple time-delay lines, they will all look identical.

@michael-s-molina
Copy link
Member

Thank you all for the discussion.

I prefer to have them display different colors, especially when we are only drawing a single indicator and want to compare the data from a week ago. Showing different colors would be very convenient for observation.

My concerns here would be:

  • Consistency on how we display offsets between charts. It will be hard for users to understand how to view offsets if we use different color strategies for every chart.
  • Multiple series and their offsets. If a bar chart has multiple series, it's hard to identify the offsets if the colors don't match.

In line charts, it makes the time-delay lines dotted instead of solid but in the same color. This is pretty nice, however, if you have multiple time-delay lines, they will all look identical.

You're correct. We would be need have a number of patterns (dashed, solid, dotted, etc) equal to the number of supported offsets to differentiate the metrics.

Tagging @kasiazjc to bring the designer's perspective to the discussion.

@cdr4321
Copy link

cdr4321 commented Feb 14, 2024

Any update on this? We recently switched over to Superset for analytics and I've been getting some complaints about this exact issue.

@eschutho
Copy link
Member

eschutho commented Mar 18, 2024

I noticed that the behavior is different when using multiple metrics and "Truncate Metric" is unselected if anyone wants to test that out for your use-case.
Screenshot 2024-03-15 at 3 04 48 PM

@mathieudruart
Copy link
Contributor

Hi @eschutho with our use-case it doesn't seem to change anything (Superset 3.0.3) :

Capture d’écran, le 2024-03-18 à 15 16 40 Capture d’écran, le 2024-03-18 à 15 16 48

@cdr4321
Copy link

cdr4321 commented Mar 18, 2024

Same for me. We are on 3.0.1

@Naga-BI
Copy link

Naga-BI commented Aug 1, 2024

Same for me. Version 3.1.3. Any update on whether the issue will be fixed?

@eschutho
Copy link
Member

eschutho commented Aug 1, 2024

We're currently looking into some improvements here. Perhaps by the 4.2 release.

@jbonaoned
Copy link

jbonaoned commented Nov 27, 2024

Hello, I'm checking in.When is the release of version 4.2 scheduled?

@rusackas
Copy link
Member

rusackas commented Dec 9, 2024

It's not clear if there will be a 4.2... though there may well be. We're beginning to focus on 5.0, so 4.x.x releases will be as-needed for patches, or as-wanted by a volunteer release manager (e.g. @sadpandajoe). You can join us on slack in the various release channels if you want to keep an ear out or get involved in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests