-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Row limit hardcoded at 100 000 in the UI #26779
Comments
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
It seem that changes in #26151 broke the UI. Setting SQL_MAX_ROW above 100 000 and trying to go over this limit results in an error in the UI, saying "value cannot exceed 100 000". Setting SQL_MAX_ROW under 100 000 results in the same error regardless of the changes to SQL_MAX_ROW. Meanwhile, when you view the chart's query from inside a dashboard, the LIMIT changes accordingly based on the SQL_MAX_ROW variable. For example, if the SQL_MAX_ROW limit is 500 000 and your chart was created before migrating to 3.1 with the same limit, the UI will not allow you to edit the chart but the LIMIT in the query itself will be set to 500 000. If you change SQL_MAX_ROW to anything below 500 000, the UI will keep the same error but the LIMIT inside the query will be lowered accordingly.
How to reproduce the bug
Screenshots/recordings
Limits inside the Docker Container:
Error message:
View query LIMIT:
Superset version
3.1.0
Python version
Not applicable
Node version
Not applicable
Browser
Not applicable
Additional context
One workaround until this is fixed is to export the chart and change the row limit inside the YAML, then import the chart. I tried changing the ROW_LIMIT variable as well, but it did not solve the issue.
Checklist
The text was updated successfully, but these errors were encountered: