Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to translate strings in javascript? #3056

Closed
3 tasks done
fufjvnvnf opened this issue Jun 28, 2017 · 1 comment
Closed
3 tasks done

How to translate strings in javascript? #3056

fufjvnvnf opened this issue Jun 28, 2017 · 1 comment

Comments

@fufjvnvnf
Copy link

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.18.5

I followed the steps described in contributing.md to translate all the strings in python, but is there a way to translate strings in javascript? For example in the explore view of any slice, sections such as "Time Column" or "Time Grain" could not be translated since they are defined in Controls.jsx, which is not a python file. Is there a way to also translate them? I'm happy to send a pr with a complete Chinese translation if this problem can be solved.

@xrmx
Copy link
Contributor

xrmx commented Jun 28, 2017

Dup of #1926

@xrmx xrmx closed this as completed Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants