Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ant Design 5: Upgrade Input component #30727

Closed
geido opened this issue Oct 28, 2024 · 2 comments · Fixed by #30730
Closed

Ant Design 5: Upgrade Input component #30727

geido opened this issue Oct 28, 2024 · 2 comments · Fixed by #30730
Assignees
@msyavuz
Labels
frontend:refactor:antd5 good first issue Good first issues for new contributors preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.

Comments

@geido
Copy link
Member

geido commented Oct 28, 2024

Please refer to SIP-139 #29268.

The Input component should be upgraded to Ant Design version 5.

Similar work has been completed here.

When upgrading the component to Ant Design 5, please ensure to include:

  • Proper RTL test coverage if not present yet.
  • A Storybook file (if not present) or all necessary changes.
  • Include all relevant component options in the Storybook.
  • Clean up unnecessary custom styles.

When opening a PR:

  • Name your PR refactor({Component}): Upgrade {component} to Ant Design 5
  • Add screenshots of BEFORE/AFTER in your PR.
  • Update the project tracker when your PR is merged.
  • Make sure you or a committer has labeled your PR with frontend:refactor:antd5.
@geido geido added good first issue Good first issues for new contributors preset:bounty Issues that have been selected by Preset and have a bounty attached. preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. labels Oct 28, 2024
@aybanda
Copy link

aybanda commented Oct 28, 2024

Hey @geido , I would like to work on this issue
can you assign this to me?

@msyavuz
Copy link
Contributor

msyavuz commented Oct 28, 2024

@geido I would like to work on this issue, i already have some work towards this.

@msyavuz msyavuz mentioned this issue Oct 28, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msyavuz msyavuz

Labels
frontend:refactor:antd5 good first issue Good first issues for new contributors preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(input): Migrate Input component to Ant Design 5 msyavuz/superset
4 participants
@geido @msyavuz @aybanda and others