Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter numerical range slider to user input fields #31345

Open
yousoph opened this issue Dec 9, 2024 · 8 comments · May be fixed by #31726
Open

Update filter numerical range slider to user input fields #31345

yousoph opened this issue Dec 9, 2024 · 8 comments · May be fixed by #31726
Assignees
Labels
change:frontend Requires changing the frontend preset:bounty:feat Features that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.

Comments

@yousoph
Copy link
Member

yousoph commented Dec 9, 2024

Screenshot

image

Description

The slider as a filter isn't an intuitive pattern and it's hard to set the filter values at a large value. Move to two input boxes instead (see below)

Design input

image

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Dec 9, 2024
@rusackas
Copy link
Member

rusackas commented Dec 9, 2024

Should we support both, and make it an option when configuring "range" filters?

@geido
Copy link
Member

geido commented Dec 11, 2024

@kasiazjc @yousoph Beto also suggested something similar to what @rusackas is proposing above. What do you guys think?

@geido
Copy link
Member

geido commented Dec 30, 2024


🎉 Preset Bounty Available: $500 USD 🎉

To claim this bounty, please carefully follow the steps below.


📋 Steps to Participate

  1. Review Guidelines:
    Read through the Preset Bounty Program Contribution Guide for complete details on bounty requirements.

  2. Show Your Interest:
    Complete the Preset Bounty Program Survey and comment this issue to express your interest.

  3. Join the Slack Channel:
    After completing the survey, you’ll receive an invitation to the dedicated Apache Superset Slack channel.

  4. Get Assigned:
    To officially start, ensure a Bounty Program Manager has assigned you to this issue.

  5. Submit Your Solution:
    When ready, submit your solution with the Fixes #{issue_number} notation in your Pull Request description.

  6. Claim Your Bounty:
    Sign up at GitPay.me and submit your solution via: https://gitpay.me/#/task/1034


💡 Additional Notes

  • Only developers assigned by a Bounty Program Manager should start working on this issue to win the bounty.
  • Be sure to follow the guide closely to avoid any delays in payment. Please, allow a few days after your PR has been merged for the bounty to be released.

Good luck, and happy coding! 🎉

@alexandrusoare
Copy link
Contributor

Hey @geido I am interested in taking this one

@Niharika0104
Copy link

@geido can I take this?

@fardin-developer
Copy link
Contributor

Hey @geido , I want to work on this.......

@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. preset:bounty:feat Features that have been selected by Preset and have a bounty attached. labels Jan 1, 2025
@alexandrusoare alexandrusoare linked a pull request Jan 6, 2025 that will close this issue
9 tasks
@kasiazjc
Copy link
Contributor

Some additional requirements: user can choose to select single value (set in settings)
Image

In this case, change field to one input only with metadata text for each of the cases:

Image

Minimum → Filters for values greater than or equal.
Maximum → Filters for values less than or equal.
Exact → Filters for values equal to this exact value.

As for the design details - we should have metadata under inputs already, so use existing component.

@elidakirigo
Copy link

hi @geido is this still open? i'd like to work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend preset:bounty:feat Features that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants