Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can query bigquery datasets without permissions #9182

Closed
micimize opened this issue Feb 20, 2020 · 5 comments
Closed

Users can query bigquery datasets without permissions #9182

micimize opened this issue Feb 20, 2020 · 5 comments
Labels
.pinned Draws attention

Comments

@micimize
Copy link
Contributor

micimize commented Feb 20, 2020

Once a user has permissions to any bigquery dataset, they can query any other dataset superset has access to, just by using the dataset prefix. This is probably because the bigquery client jobs have no dataset restrictions googleapis/google-cloud-python#6042

@willbarrett
Copy link
Member

As mentioned in the linked ticket, the current correct behavior is to manage access at the Google Cloud API layer. The client library is not able to make restrictions like the one described in this ticket, thus Superset is similarly limited. Thank you for bringing this to our attention.

@stale
Copy link

stale bot commented Apr 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 25, 2020
@micimize
Copy link
Contributor Author

This should probably be .pinned

@stale stale bot removed the inactive Inactive for >= 30 days label Apr 25, 2020
@rusackas rusackas added the .pinned Draws attention label Apr 28, 2020
@micimize
Copy link
Contributor Author

The referenced python-bigquery issue was closed in favor of adding conditional IAM support to bigquery. Once/if that is done, I think superset could add a field to the request with a list of authenticated datasets and have a recommended IAM policy to set.

@graceguo-supercat
Copy link

close this since no recent follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.pinned Draws attention
Projects
None yet
Development

No branches or pull requests

4 participants