Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update migration logic in #27119 #28482

Merged
merged 2 commits into from
May 20, 2024
Merged

fix: Update migration logic in #27119 #28482

merged 2 commits into from
May 20, 2024

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented May 13, 2024 •
edited
Loading

SUMMARY

This PR is a follow up #28422 (which needs to be cherry-picked to remedy an issue, but can't include a migration). Specifically it also adds a new migration to resize specific columns back to LONGTEXT if the previous migration has already been run. If not, the migration is a no-op.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the risk:db-migration PRs that require a DB migration label May 13, 2024
@john-bodley john-bodley mentioned this pull request May 13, 2024
Merged
9 tasks
@john-bodley john-bodley added the risk:may-require-downtime Upgrading to this feature may require downtime label May 13, 2024
@john-bodley john-bodley force-pushed the john-bodley--migration-longtext branch from 8a8a210 to 2cc5ee3 Compare May 13, 2024 18:17
@john-bodley john-bodley force-pushed the john-bodley--migration-longtext branch from 2cc5ee3 to d72f46c Compare May 14, 2024 18:02
@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.48%. Comparing base (76d897e) to head (19423bc).
Report is 1094 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #28482       +/-   ##
===========================================
+ Coverage   60.48%   83.48%   +22.99%     
===========================================
  Files        1931      521     -1410     
  Lines       76236    37484    -38752     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31294    -14820     
+ Misses      28017     6190    -21827     
+ Partials     2105        0     -2105
Flag Coverage Δ
hive 49.09% <ø> (-0.07%) ⬇️
javascript ?
mysql 77.15% <ø> (?)
postgres 77.28% <ø> (?)
presto 53.64% <ø> (-0.16%) ⬇️
python 83.48% <ø> (+19.99%) ⬆️
sqlite 76.73% <ø> (?)
unit 58.94% <ø> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley marked this pull request as ready for review May 14, 2024 19:09
@john-bodley john-bodley requested a review from a team as a code owner May 14, 2024 19:09
@dosubot dosubot bot added the change:backend Requires changing the backend label May 14, 2024
mistercrunch
mistercrunch approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit 1c48fe0 into apache:master May 20, 2024
35 checks passed
Vitor-Avila pushed a commit to Vitor-Avila/superset that referenced this pull request May 28, 2024
@john-bodley @Vitor-Avila
fix: Update migration logic in apache#27119 (apache#28482)
ea39770
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@john-bodley @EnxDev
fix: Update migration logic in apache#27119 (apache#28482)
de30461
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@john-bodley
fix: Update migration logic in apache#27119 (apache#28482)
57ffef7
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:backend Requires changing the backend risk:db-migration PRs that require a DB migration risk:may-require-downtime Upgrading to this feature may require downtime size/M 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-bodley @mistercrunch @michael-s-molina