Skip to content

Commit 29bd999

Browse files
committed
Refactor default cipher lists
1 parent 4a3ea92 commit 29bd999

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

java/org/apache/tomcat/util/net/SSLHostConfig.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,14 @@ public class SSLHostConfig implements Serializable {
5959
// keys in Maps.
6060
protected static final String DEFAULT_SSL_HOST_NAME = "_default_";
6161
protected static final Set<String> SSL_PROTO_ALL_SET = new HashSet<>();
62-
protected static final String DEFAULT_TLS_12_BELOW_CIPHERS = "HIGH:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5:!kRSA";
63-
protected static final String DEFAULT_TLS_13_ABOVE_CIPHERS = "TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256";
64-
public static final String DEFAULT_TLS_CIPHERS = DEFAULT_TLS_12_BELOW_CIPHERS + ":" + DEFAULT_TLS_13_ABOVE_CIPHERS;
62+
public static final String DEFAULT_TLS_CIPHERS_12 = "HIGH:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5:!kRSA";
63+
public static final String DEFAULT_TLS_CIPHERS_13 = "TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256";
64+
/**
65+
* Default cipher list for TLS 1.2 and below.
66+
* @deprecated Replaced by {@link #DEFAULT_TLS_CIPHERS_12}
67+
*/
68+
@Deprecated
69+
public static final String DEFAULT_TLS_CIPHERS = DEFAULT_TLS_CIPHERS_12;
6570

6671
static {
6772
/*

java/org/apache/tomcat/util/net/SSLUtilBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ protected SSLUtilBase(SSLHostConfigCertificate certificate, boolean warnTls13) {
128128
// OpenSSL profiles cannot be resolved without Java 22
129129
this.enabledCiphers = new String[0];
130130
} else {
131-
boolean warnOnSkip = !sslHostConfig.getCiphers().equals(SSLHostConfig.DEFAULT_TLS_CIPHERS);
131+
boolean warnOnSkip = !sslHostConfig.getCiphers().equals(SSLHostConfig.DEFAULT_TLS_CIPHERS_12);
132132
List<String> configuredCiphers = sslHostConfig.getJsseCipherNames();
133133
Set<String> implementedCiphers = getImplementedCiphers();
134134
List<String> enabledCiphers =

0 commit comments

Comments
 (0)