Skip to content

Commit 093aff5

Browse files
author
Walter Karas
committed
Make sure, when plugins for a GET request to fail, there is always a response body.
Also add classes to CPP API for convenient manipulation of components of HTTP messagess. These classes may be used independently of other parts of the TS CPP API. (This PR is absorbing PR #5812.) Adds Au test with plugin forcing various errors on various hooks, with default body or set body.
1 parent 219b886 commit 093aff5

File tree

16 files changed

+2232
-10
lines changed

16 files changed

+2232
-10
lines changed
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,13 @@ class TxnAuxDataMgrBase
124124

125125
using TxnAuxMgrData = TxnAuxDataMgrBase::MgrData;
126126

127-
// Class to manage auxiliary data for a transaction. If an instance is created for the transaction, the instance
128-
// will be deleted on the TXN_CLOSE transaction hook (which is always triggered for all transactions).
129-
// The TxnAuxData class must have a public default constructor.
127+
// Class to manage auxiliary data for a transaction. If an instance of auxiliary data is created for the
128+
// transaction, the instance will be deleted on the TXN_CLOSE transaction hook (which is always triggered
129+
// for all transactions). The TxnAuxData class must have a public default constructor.
130+
//
131+
// This class and the base class are pseudo-namespaces, have only static member functions (no data members).
132+
// The manager data cannot simply be in the base class, because the (static member) continuation function that
133+
// runs on the TXN_CLOSE hook would not be able to access it.
130134
//
131135
template <class TxnAuxData, TxnAuxMgrData &MDRef> class TxnAuxDataMgr : private TxnAuxDataMgrBase
132136
{

0 commit comments

Comments
 (0)