Build test C/C++ files with Automake.

Many AuTests have test plugins or test executables that are used as a
part of the test. Before this change these were built by ad hoc calls to
g++ or gcc via shell executions from within the test or one of a couple
AuTest extensions. This patch removes the building of these files from
AuTest and instead uses the Automake build system to build these. This
will build these utilities in a way that is consistent with the rest of
the system, using the same warning and error flags, the same
clang tool configurations, etc.

Author: bneradt

.gitignore

@@ -193,6 +193,8 @@ RELEASE
 # autest
 tests/env-test/
 tests/Pipfile.lock
+tests/gold_tests/chunked_encoding/smuggle-client
+tests/gold_tests/tls/ssl-post
 
 iocore/cache/test_*
 iocore/cache/test/var/trafficserver/cache.db

Makefile.am

@@ -27,7 +27,7 @@ export CCACHE_BASEDIR
 # and mgmt, hence we have to build proxy/hdrs first.
 
 # depends on the generates ts/ts.h include file.
-SUBDIRS = src/tscpp/util lib src/tscore iocore proxy mgmt src plugins tools example rc configs include
+SUBDIRS = src/tscpp/util lib src/tscore iocore proxy mgmt src plugins tools example rc configs include tests
 
 if BUILD_DOCS
 SUBDIRS += doc include

configure.ac

@@ -2216,6 +2216,7 @@ AC_CONFIG_FILES([
   tools/trafficserver.pc
   tools/tsxs
   tests/unit_tests/Makefile
+  tests/Makefile
 ])
 
 # -----------------------------------------------------------------------------

tests/Makefile.am

@@ -0,0 +1,42 @@
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+include $(top_srcdir)/build/plugins.mk
+include $(top_srcdir)/build/tidy.mk
+
+noinst_LTLIBRARIES =
+noinst_PROGRAMS =
+
+SUBDIRS =
+
+AM_LDFLAGS += $(TS_PLUGIN_LD_FLAGS)
+
+# Automake is pretty draconian about not creating shared object (.so) files for
+# non-installed files. However we do not want to install our test plugins so
+# we prefix them with noinst_.  The following -rpath argument coerces the
+# generation of so objects for these test files.
+AM_LDFLAGS += -rpath $(abs_builddir)
+
+include gold_tests/continuations/plugins/Makefile.inc
+include gold_tests/chunked_encoding/Makefile.inc
+include gold_tests/tls/Makefile.inc
+include tools/plugins/Makefile.inc
+
+TESTS = $(check_PROGRAMS)
+
+clang-tidy-local: $(DIST_SOURCES)
+	$(CXX_Clang_Tidy)
+	$(CC_Clang_Tidy)

tests/gold_tests/autest-site/build.test.ext

@@ -80,6 +80,7 @@ if ENV['ATS_BIN'] is not None:
     Variables.update(out)
 Variables.AtsExampleDir = os.path.join(AutestSitePath, '../../../example')
 Variables.AtsTestToolsDir = os.path.join(AutestSitePath, '../../tools')
+Variables.AtsTestPluginsDir = os.path.join(AutestSitePath, '../../tools/plugins/.libs')
 
 # modify delay times as we always have to kill Trafficserver
 # no need to wait

tests/gold_tests/autest-site/setup.cli.ext

@@ -19,47 +19,33 @@ Builds, installs, and enables an ATS plugin in the sandbox environment
 
 import os
 
-def prepare_plugin(self, path, tsproc, plugin_args = "", extra_build_args=''):
-    """Builds, installs, and enables an ATS plugin in the sandbox environment
 
-    The source file at the given path is copied to the sandbox directory of the
-    given traffic server process and compiled into a binary with the file
-    extensioned replaced with '.so'. An entry for this plugin is added to
-    the 'plugin.config' file."""
+def prepare_plugin(self, so_path, tsproc, plugin_args=""):
+    """
+    Installs and enables an ATS plugin in the sandbox environment.
 
-    # Copy the source to the sandbox directory.
-    plugin_dir = tsproc.Env['PROXY_CONFIG_PLUGIN_PLUGIN_DIR']
-    tsproc.Setup.Copy(path, plugin_dir)
+    Args:
+        so_path (str): The path to a built .so file.
+
+        tsproc (Process): The Traffic Server process whose plugin.config should
+        be configured to use the provided plugin.
 
-    tsxs = os.path.join(self.Variables.BINDIR,'tsxs')
-    # get the top level object ( ie Test) to add a condition
-    # need to change this API in AuTest to be a better name as it now has value
-    # to be called by user API - dragon512
-    self._RootRunable.SkipUnless(
-        Condition.HasProgram(tsxs, "tsxs needs be installed with trafficserver package for this test to run")
-        )
+        plugin_args (str): The arguments to provide the plugin in the
+        plugin.config.
+    """
 
-    link_gxx="export CC=c++ &&"
-    # Compile the plugin.
-    in_basename = os.path.basename(path)
-    if in_basename.endswith(".c"):
-        link_gxx = ''
-    in_path = os.path.join(plugin_dir, in_basename)
-    out_basename = os.path.splitext(in_basename)[0] + '.so'
-    out_path = os.path.join(plugin_dir, out_basename)
-    tsproc.Setup.RunCommand(
-        "{pre_args} {tsxs} {args} -c {0} -o {1}".format(
-            in_path,
-            out_path,
-            tsxs=tsxs,
-            args=" -L {0} {1}".format(self.Variables.LIBDIR, extra_build_args),
-            pre_args=link_gxx)
-    )
+    filename, extension = os.path.splitext(so_path)
+    if extension != ".so":
+        raise ValueError('so_path argument must have a ".so" extension. '
+                         'Received: {}'.format(so_path))
+
+    # Copy the shared object to the sandbox directory.
+    plugin_dir = tsproc.Env['PROXY_CONFIG_PLUGIN_PLUGIN_DIR']
+    tsproc.Setup.Copy(so_path, plugin_dir)
 
     # Add an entry to plugin.config.
-    tsproc.Disk.plugin_config.AddLine("{0} {1}".format(out_basename,plugin_args))
+    basename = os.path.basename(so_path)
+    tsproc.Disk.plugin_config.AddLine("{0} {1}".format(basename, plugin_args))
 
-# remove this later
-ExtendTest(prepare_plugin, name="prepare_plugin")
 
 ExtendTest(prepare_plugin, name="PreparePlugin")

tests/gold_tests/autest-site/trafficserver_plugins.test.ext

@@ -37,7 +37,7 @@
 )
 ts.Disk.MakeConfigFile(regex_remap_conf_file).AddLine('//.*/ http://donotcare.test @status=204')
 
-Test.PreparePlugin(os.path.join(Test.Variables.AtsTestToolsDir, 'plugins', 'custom204plugin.cc'), ts)
+Test.PreparePlugin(os.path.join(Test.Variables.AtsTestPluginsDir, 'custom204plugin.so'), ts)
 
 Test.Setup.Copy(os.path.join(os.pardir, os.pardir, 'tools', 'tcp_client.py'))
 Test.Setup.Copy('data')

tests/gold_tests/body_factory/http204_response_plugin.test.py

@@ -0,0 +1,19 @@
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+noinst_PROGRAMS += gold_tests/chunked_encoding/smuggle-client
+gold_tests_chunked_encoding_smuggle_client_SOURCES = gold_tests/chunked_encoding/smuggle-client.c
+gold_tests_chunked_encoding_smuggle_client_LDADD = -lssl

tests/gold_tests/chunked_encoding/Makefile.inc

@@ -90,10 +90,9 @@
     'dest_ip=* ssl_cert_name=server.pem ssl_key_name=server.key'
 )
 
-# build test code
-tr = Test.Build(target='smuggle-client', sources=['smuggle-client.c'])
-tr.TimeOut = 5
-tr.Setup.Copy('smuggle-client.c')
+# smuggle-client is built via `make`. Here we copy the built binary down to the
+# test directory so that the test runs in this file can use it.
+Test.Setup.Copy('smuggle-client')
 
 # HTTP1.1 GET: www.example.com
 tr = Test.AddTestRun()