Fix CID 1508979: unchecked return value (#10281)

shukitchan · web-flow · commit 8659235196ea · 2023-08-25T13:19:23.000-07:00
diff --git a/plugins/lua/ts_lua_util.cc b/plugins/lua/ts_lua_util.cc
@@ -53,7 +53,10 @@ void
 ts_lua_update_server_response_hdrp(ts_lua_http_ctx *http_ctx)
 {
   if (http_ctx->server_response_hdrp) {
-    TSHttpTxnServerRespGet(http_ctx->txnp, &http_ctx->server_response_bufp, &http_ctx->server_response_hdrp);
+    if (TSHttpTxnServerRespGet(http_ctx->txnp, &http_ctx->server_response_bufp, &http_ctx->server_response_hdrp) != TS_SUCCESS) {
+      TSError("[ts_lua][%s] failed to get server response", __FUNCTION__);
+      return;
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,10 @@ void`
`53`	`53`	`ts_lua_update_server_response_hdrp(ts_lua_http_ctx *http_ctx)`
`54`	`54`	`{`
`55`	`55`	`if (http_ctx->server_response_hdrp) {`
`56`		`- TSHttpTxnServerRespGet(http_ctx->txnp, &http_ctx->server_response_bufp, &http_ctx->server_response_hdrp);`
	`56`	`+ if (TSHttpTxnServerRespGet(http_ctx->txnp, &http_ctx->server_response_bufp, &http_ctx->server_response_hdrp) != TS_SUCCESS) {`
	`57`	`+ TSError("[ts_lua][%s] failed to get server response", __FUNCTION__);`
	`58`	`+ return;`
	`59`	`+ }`
`57`	`60`	`}`
`58`	`61`	`}`
`59`	`62`