-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPP] Add unit test #111
Comments
Hi, this is your first issue in the Apache TsFile project. Thanks for your report. Welcome to join the community! |
So this is more a legal than a technical question .. from a quick check Gtest is BSD 3-Clause Licensed, which is ok .. CppUnit is GPL licensed, which is not ok. We probably should remove the tooling for Unity integration as this seems to be a pure C test setup which we will most probably not be using. |
This looks as if integrating it into our build would be simple: |
Good job. But I am afraid that we are facing something more challenging: verifying that TsFiles generated by the CPP edition can be read by the Java edition and vice versa. The motivation is that I just found the dictionary encoding implementation is different on both sides. Other similar issues would better be detected automatically. Any idea about this? |
I guess an "integration-test" sub-module makes sense for this ... I would however think that this issue is about unit-testing the Cpp code itself, right? |
Of course, we should open another issue for it. |
The unit test framework chosen is GTest, as recommended by Chris. |
Does the TsFile_CPP project require unit tests? Can we use third-party libraries such as Gtest or CppUnit ?
The text was updated successfully, but these errors were encountered: