Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] USE_LIBTORCH is disabled in all builds #12736

Open
2 tasks
leandron opened this issue Sep 8, 2022 · 1 comment
Open
2 tasks

[Bug] USE_LIBTORCH is disabled in all builds #12736

leandron opened this issue Sep 8, 2022 · 1 comment

Comments

@leandron
Copy link
Contributor

leandron commented Sep 8, 2022

On my journey in enabling Integration tests in AArch64, I stumbled upon ctypes.tests.python.contrib.test_libtorch_ops.test_backend (see full error here), which crashes running integration tests on machines with torch installed.

The reason for that, is because TVM was not compiled with USE_LIBTORCH ON, and therefore the relevant sources won't be compiled into the output TVM libs. I am opening this as a tracking issue to enable USE_LIBTORCH, so that corresponding test(s) don't get stale.

This is also related to #12529, in which we probably want to enable Integration tests in CI_GPU.

In my view we need to:

  • Document USE_LIBTORCH in our example config.cmake
  • Activate USE_LIBTORCH in the build config script (the AArch64 seems the best positioned as of now)
@areusch areusch added the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Oct 19, 2022
@janetsc janetsc added byoc:libtorch and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 19, 2022
@cchung100m
Copy link
Contributor

Hi @leandron

Do we finish the fix now? I think we can close this issue if the answer is yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants