Skip to content

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Jan 5, 2026

Why

The flip operator lacked layout inference support, preventing it from participating in layout transformations during the ConvertLayout pass.

How

  • Add InferLayoutFlip function that transforms the axis attribute according to the input layout
  • Register FRelaxInferLayout attribute for relax.flip operator
  • Add test case for conv2d followed by flip with layout conversion

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the relax.flip operator into Relax's layout transformation system by providing a dedicated layout inference function. This enhancement allows the system to automatically adjust the flip operation's axis when tensor data layouts are converted, which is crucial for maintaining correctness and enabling performance optimizations across various hardware backends.

Highlights

  • FRelaxInferLayout for relax.flip: Implemented the FRelaxInferLayout attribute for the relax.flip operator, enabling it to participate in layout transformation passes within the Relax framework.
  • Axis Transformation Logic: Added robust logic within InferLayoutFlip to correctly transform the axis attribute of the flip operation based on the input tensor's layout changes, ensuring functional correctness across different data layouts.
  • New Test Case for Layout Conversion: Introduced test_conv2d_flip to thoroughly validate the relax.flip operator's behavior when combined with layout transformations, specifically demonstrating its interaction with conv2d and permute_dims.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds layout inference support for the relax.flip operator, which is a great addition. The implementation in InferLayoutFlip is correct, and the new test case test_conv2d_flip effectively validates the changes. My main feedback is to simplify the logic for finding the transformed axis by using the existing FindAxis utility function, which will improve code readability and maintainability.

@guan404ming guan404ming force-pushed the add-flip-layout-inference branch from f22d0db to 5a97ca5 Compare January 5, 2026 17:40
@guan404ming guan404ming force-pushed the add-flip-layout-inference branch from 5a97ca5 to 2b2c38a Compare January 6, 2026 03:42
@guan404ming guan404ming marked this pull request as ready for review January 6, 2026 05:39
@guan404ming
Copy link
Member Author

cc @tlopex @mshr-h

@mshr-h mshr-h merged commit a95b90c into apache:main Jan 6, 2026
13 checks passed
@guan404ming guan404ming deleted the add-flip-layout-inference branch January 6, 2026 06:34
@guan404ming
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants