[Relax] Add FRelaxInferLayout for scatter_elements operator

[guan404ming]

Why

The scatter_elements operator was missing FRelaxInferLayout support, which prevented proper layout transformation when used with operators like conv2d that require layout conversion.

How

• Implement InferLayoutScatterElements function that handles layout inference for scatter_elements
• Transform axis attribute according to the inferred layout using FindAxis
• Handle sub-indexed layout fallback to initial layout
• Add test case for conv2d + scatter_elements layout conversion

[gemini-code-assist]

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical gap in the Relax framework by integrating layout inference capabilities for the scatter_elements operator. By implementing FRelaxInferLayout, the system can now correctly handle data layout transformations for scatter_elements, ensuring seamless integration and optimized performance when this operator is part of a larger computational graph involving layout-sensitive operations.

Highlights

• FRelaxInferLayout for scatter_elements: Added FRelaxInferLayout support for the scatter_elements operator, which was previously missing.
• Improved Layout Transformation: This change enables proper layout transformation for scatter_elements, especially when used in conjunction with other operators like conv2d that require layout conversion.
• Implementation Details: The implementation includes the InferLayoutScatterElements function, logic to transform the axis attribute based on the inferred layout using FindAxis, and handling for sub-indexed layout fallback to the initial layout.
• New Test Case: A new test case (test_conv2d_scatter_elements) has been added to validate the layout conversion for conv2d followed by scatter_elements.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds layout inference support for the scatter_elements operator in TVM Relax, enabling proper layout transformations when used with other operators like conv2d. The implementation introduces InferLayoutScatterElements, which determines the appropriate layout for the operator's inputs and output, and updates the axis attribute accordingly. It includes a fallback mechanism for sub-indexed layouts, defaulting to the initial layout. A new test case is added to verify the functionality in a conv2d -> scatter_elements chain.

The changes are logical and well-tested. I have a couple of suggestions to improve code clarity and maintainability by making ICHECK messages more specific and adding a comment to explain the sub-indexed layout fallback logic.

[guan404ming]

cc @tlopex @mshr-h

[mshr-h]

Please resolve the conflict so that we can merge. cc @guan404ming

[guan404ming]

Please resolve the conflict so that we can merge. cc @guan404ming

Thanks, I've resolved it.