-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC][Frontend] Return module for Relay frontend converter #3346
Comments
Yeah, this is exactly what I think as well. |
+1 |
1 similar comment
+1 |
8 tasks
@icemelon9 #3353 was the draft I haven't finished yet. |
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As we have pass manager in Relay optimization and mostly use module as optimization unit, I suggest we change the Relay frontend converter to return a module instead of a function. The change also makes easier add prelude and global var in the frontend converter in the future. Frontend converter will preset the main function in the module to the converted function as
Correspondingly we need to change the relay executor to be able to run the converted module. I use MxNet as an exmple to show the proposed change:
When executor is given no input, it will execute the
mod.entry_func
by default.cc @jroesch @tqchen @wweic @zhiics
The text was updated successfully, but these errors were encountered: