Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Docker] ubuntu_install_sgx.sh breaks when trying to download patch file #4946

Closed
leandron opened this issue Feb 26, 2020 · 3 comments · Fixed by #4948
Closed

[CI][Docker] ubuntu_install_sgx.sh breaks when trying to download patch file #4946

leandron opened this issue Feb 26, 2020 · 3 comments · Fixed by #4948

Comments

@leandron
Copy link
Contributor

ubuntu_install_sgx.sh points to a patch file on a GitHub gist, which now seems to be removed. This makes the process of rebuilding the Docker images that invoke ubuntu_install_sgx.sh to crash.

This is the relevant line:
https://github.com/apache/incubator-tvm/blob/588523ddb6e938637d96745bcce145375307247f/docker/install/ubuntu_install_sgx.sh#L40

The repository name changed as well (probably not very relevant for the issue here), from https://github.com/baidu/rust-sgx-sdk to https://github.com/apache/incubator-teaclave-sgx-sdk.

I'm not very familiar with the Rust SGX SDK, that is why I'm asking: is this patch something we still need, or is it something that needs to be removed from the script?

@tqchen
Copy link
Member

tqchen commented Feb 26, 2020

cc @nhynes

@nhynes
Copy link
Member

nhynes commented Feb 26, 2020

hmm, I'll fix this now. SGX is unfortunately quite deprecated at this time (😬) and I think it reasonable to temporarily remove.

Update: apparently one can possibly recover a lost gist. I've followed the suggested answer and can only now wait. I hate breaking the build, so there's #4948, for expediency.

@leandron
Copy link
Contributor Author

leandron commented Mar 2, 2020

Thanks for fixing this, but I would suggest another issue to track the need for a proper fix for this?

Further, there is a this app[1], that uses ubuntu_install_sgx.sh, which in practice still depends on this GitHub gist and thus needs to be fixed as well. How do we not lose this information?

[1] https://github.com/apache/incubator-tvm/tree/cffb4fba03ea582417e2630bd163bca773756af6/apps/sgx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants