[RELAY] Remove primitive attribute from composite function #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* A composite function should not be primitive since we still may need to perform passes on it. Change-Id: If62d06d265234861a6ec0df7749dc1c339c1055c
mbaret
approved these changes
Mar 9, 2020
zhiics
approved these changes
Mar 9, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* A composite function should not be primitive since we still may need to perform passes on it. Change-Id: If62d06d265234861a6ec0df7749dc1c339c1055c
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* A composite function should not be primitive since we still may need to perform passes on it. Change-Id: If62d06d265234861a6ec0df7749dc1c339c1055c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composite functions are wrongly marked as primitive - we may still want to run passes on ops inside the composite function. For example, this will allow the fold constant pass to be run after the merge composite pass has been run.