[REFACTOR][TIR] Introduce PrimFuncPass. #5139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce PrimFuncPass - Convert one pass to the unified Pass API.
|
cc @yzhliu @kazum @vinx13 @merrymercy @Hzfengsy @ZihengJiang @wweic @zhiics @icemelon9 @jroesch |
zhiics
reviewed
Mar 24, 2020
|
|
||
| @tvm._ffi.register_object("tir.PrimFuncPass") | ||
| class PrimFuncPass(Pass): | ||
| """A pass that works on each tvm.relay.Function in a module. A function |
|
|
||
| Parameters | ||
| ---------- | ||
| pass_func : Optional[Callable[(Function, Module, PassContext) -> Function]] |
There was a problem hiding this comment.
Function->PrimFunc
Module->IRModule
| name of the optimization function will be used as the pass name. | ||
|
|
||
| required : Optional[List[str]] | ||
| The list of passes that the module pass is dependent on. |
siju-samuel
reviewed
Mar 24, 2020
src/tir/ir/transform.cc
Outdated
| * \brief Run a function pass on given pass context. | ||
| * | ||
| * \param mod The module that an optimization pass is applied on. | ||
| * \param mod The context that an optimization pass executes on. |
| assert f.body.value.dtype == "handle" | ||
| assert f.body.body.value.dtype == "handle" | ||
|
|
||
| # temp adapter t convert loweredFunc to IRModule |
zhiics
approved these changes
Mar 24, 2020
|
Thanks @zhiics @siju-samue哈 |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* [REFACTOR][TIR] Introduce PrimFuncPass. - Introduce PrimFuncPass - Convert one pass to the unified Pass API. * Address comments * Fix comments
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* [REFACTOR][TIR] Introduce PrimFuncPass. - Introduce PrimFuncPass - Convert one pass to the unified Pass API. * Address comments * Fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the unified IR refactor. We will convert all TIR passes into tir.transform and tir.analysis namespace. The passes under tir.transform shares the same Pass infra as relay. Which takes a IRModule(with PrimFuncs) and return a updated IRModule
In order to keep things backward compatible, we will keep the old API around until most of the passes has been converted. Then we will do a bulk remove of the legacy API