Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding rel="noopener" to links with target=\"_blank \" #326

Closed
raboof opened this issue Nov 7, 2023 · 4 comments
Closed

Consider adding rel="noopener" to links with target=\"_blank \" #326

raboof opened this issue Nov 7, 2023 · 4 comments

Comments

@raboof
Copy link
Member

raboof commented Nov 7, 2023

While with apache.org being a static site with no sensitive information or login functionality (and us typically trusting the sites we link to) the risk is small, but it might still be good practice to add https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel/noopener

@nsundriyal62
Copy link

@raboof i want to work on this issue
can you please elaborate it more.

@gstein
Copy link
Member

gstein commented Nov 21, 2023

noopener is implied for most current browsers.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#browser_compatibility

@krishna-dave206
Copy link

@raboof Is the issue fixed? If not I can work on this.

@raboof
Copy link
Member Author

raboof commented Jan 27, 2025

I think @gstein's observation that this is no longer useful is correct, closing

@raboof raboof closed this as completed Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants