Skip to content

[ZEPPELIN-1052] Application does not logout user when authcBasic is used #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prabhjyotsingh wants to merge 2 commits into from
Closed

[ZEPPELIN-1052] Application does not logout user when authcBasic is used #1071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3d6935
set username and password false on logout
prabhjyotsingh Jun 23, 2016
6f4dd09
force authcBasic by setting credentials as false:false
prabhjyotsingh Jun 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 26 additions & 18 deletions zeppelin-web/src/components/navbar/navbar.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ angular.module('zeppelinWebApp')
return notebook;
}

if (notebook.children) {
if (notebook.children) {
filteringNote(notebook.children, filteredNotes);
}
});
Expand Down Expand Up @@ -108,23 +108,31 @@ angular.module('zeppelinWebApp')
});

$scope.logout = function() {
$http.post(baseUrlSrv.getRestApiBase()+'/login/logout')
.success(function(data, status, headers, config) {
$rootScope.userName = '';
$rootScope.ticket.principal = '';
$rootScope.ticket.ticket = '';
$rootScope.ticket.roles = '';
BootstrapDialog.show({
message: 'Logout Success'
});
setTimeout(function() {
window.location = '#';
window.location.reload();
}, 1000);
}).
error(function(data, status, headers, config) {
console.log('Error %o %o', status, data.message);
});
var logoutURL = baseUrlSrv.getRestApiBase() + '/login/logout';
var request = new XMLHttpRequest();

//force authcBasic (if configured) to logout by setting credentials as false:false
request.open('post', logoutURL, true, 'false', 'false');
request.onreadystatechange = function() {
if (request.readyState === 4) {
if (request.status === 401 || request.status === 405) {
$rootScope.userName = '';
$rootScope.ticket.principal = '';
$rootScope.ticket.ticket = '';
$rootScope.ticket.roles = '';
BootstrapDialog.show({
message: 'Logout Success'
});
setTimeout(function() {
window.location.replace('/');
}, 1000);
} else {
request.open('post', logoutURL, true, 'false', 'false');
request.send();
}
}
};
request.send();
};

$scope.search = function(searchTerm) {
Expand Down