Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let DeadChests look for "safe" solid blocks when player dies in lava (or water) #47

Open
LaurenceBarnes opened this issue Jul 23, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@LaurenceBarnes
Copy link

Is your feature request related to a problem? Please describe.
Normally, it is quite annoying that DeadChests spawn right where the player died, specifically when it is inside of lava.

Some servers that use DeadChest, might for example do so because they wish players to not lose inventories when dying in lava. As of now, the DeadChest will spawn right in the lava. While that surely still is recoverable, there is a legitimate reason to wish for an alternative solution for this.

Describe the solution you'd like
The solution: A config option that allows to use a search radius when players die in lava (and possibly, for water and air deaths too, but separately in this case). It would look for the nearest solid block that has any kind of air (cave air, normal air, and whatever there is) on top of it.

For water and air I'd suggest to slightly change the approach. In either case it would be fine if it spawns just on the nearest solid block, does not matter whether it is covered with water or air.

Such kind of function might however use up some performance, although just happening rather rarely (depending on server size). If that is an issue that cannot be solved by using efficient methods, a limit as to how far it looks for spawning a DeadChest could be implemented.

Describe alternatives you've considered
Well just dealing with it 😎 :(

Additional context

  • none -
@LaurenceBarnes LaurenceBarnes added the enhancement New feature or request label Jul 23, 2022
@apavarino apavarino self-assigned this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants