Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items on 1.21 not stacking with other items #80

Open
Mcklp opened this issue Jun 21, 2024 · 5 comments
Open

Items on 1.21 not stacking with other items #80

Mcklp opened this issue Jun 21, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Mcklp
Copy link

Mcklp commented Jun 21, 2024

Items on 1.21 have different nbt data making them impossible to stack with other items

  • Deadchest
  • 4.21.0
  • 1.21
  • This server is running Paper version 1.21-15-master

Describe the bug
Items from deadchest have one additional component listed after hovering on them, making it impossible to stack with items that are not from deadchest. Using command "/data get entity @s SelectedItem" they have "minecrfat:damage": 0 (i added a photo).
Despite that deadchest work for me on 1.21

To Reproduce
Steps to reproduce the behavior:

  1. Get 2 same stackable items
  2. Get killed with one of it
  3. Pickup dead chest
  4. Try to stack them

Expected behavior
Items from dead chest to be the same as the rest of the items.

Screenshots
image

@Mcklp Mcklp added the bug Something isn't working label Jun 21, 2024
@leshicodes
Copy link

Not the Author, but If I am not mistaken I believe the highest supported version for this plugin is 1.20.6 right?

@Mcklp Mcklp closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
@Mcklp
Copy link
Author

Mcklp commented Jun 27, 2024

Yeah, thats right @leshicodes, but i wanted to write my observations to maybe help with updating it to 1.21. I know that this version isnt supported and thats why something like that happened. (I accidentally closed this thread sorry i reopened it)

@Mcklp Mcklp reopened this Jun 27, 2024
@leshicodes
Copy link

@Mcklp very fair, and I had a feeling that's what your intentions were. I am a novice programmer so I might see if I can create a PR to support 1.21 unless the author disapproves.

@apavarino apavarino self-assigned this Jul 4, 2024
@apavarino
Copy link
Owner

Hello, thanks for the report, it's a good help for me to provide a stable 1.21 version. I'm currently working on it. Stay tunned !

@apavarino
Copy link
Owner

Seems to be a paper issue. I made few tests, deadchest handle well item meta and NBT tags. But something is different from deachest block and game block. I compare values of ItemStack, this is strictly the same. i think it's something internal to the API. I will do more test when 1.21 Paper version will be more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants