Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different logic to compute nSamples in two different places #70

Open
NagabhushanSN95 opened this issue Aug 9, 2023 · 0 comments
Open

Comments

@NagabhushanSN95
Copy link

Hi, I noticed you're computing nSamples in two different places with slightly different logic.
In utils.py, it is simple logic. We need two samples for every unit length of voxels, so you compute the voxel/tensor grid diagonal length and multiply it by 2. But in tensorBase.py, there is some complicated logic that I guess is only slightly different from the former.

Can you kindly explain if this has any impact, or is it just a simple oversight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant