Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] some compilation complain when build the binary from source #473

Closed
cnut opened this issue Oct 21, 2024 · 1 comment
Closed

[BUG] some compilation complain when build the binary from source #473

cnut opened this issue Oct 21, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cnut
Copy link

cnut commented Oct 21, 2024

Describe the bug

# on the main branch
make kbcli
...
...
/home/glenn/ws/golang/bin/golangci-lint run ./...
WARN [config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`.
WARN [config_reader] The configuration option `output.format` is deprecated, please use `output.formats`
pkg/cmd/kubeblocks/uninstall.go:356:24: printf: non-constant format string in call to github.com/pkg/errors.Errorf (govet)
                return errors.Errorf(errMsg.String())
                                     ^
pkg/cmd/cluster/config_edit.go:202:25: printf: non-constant format string in call to github.com/apecloud/kbcli/pkg/printer.Warning (govet)
        printer.Warning(o.Out, promptStr)
                               ^
pkg/cmd/cluster/config_ops.go:204:25: printf: non-constant format string in call to github.com/apecloud/kbcli/pkg/printer.Warning (govet)
        printer.Warning(o.Out, restartConfirmPrompt)
                               ^
pkg/cmd/cluster/config_ops.go:217:30: printf: non-constant format string in call to github.com/apecloud/kubeblocks/pkg/configuration/core.MakeError (govet)
                return nil, core.MakeError(missingUpdatedParametersErrMessage)
                                           ^
pkg/cmd/cluster/config_wrapper.go:117:25: printf: non-constant format string in call to github.com/apecloud/kubeblocks/pkg/configuration/core.MakeError (govet)
                return core.MakeError(multiComponentsErrorMessage)
                                      ^
pkg/cmd/cluster/config_wrapper.go:156:25: printf: non-constant format string in call to github.com/apecloud/kubeblocks/pkg/configuration/core.MakeError (govet)
                return core.MakeError(multiConfigTemplateErrorMessage)
                                      ^
pkg/cmd/playground/destroy.go:155:27: printf: non-constant format string in call to github.com/apecloud/kbcli/pkg/printer.Warning (govet)
                        printer.Warning(o.Out, err.Error())
                                               ^
pkg/cmd/playground/init.go:484:23: printf: non-constant format string in call to fmt.Fprintf (govet)
                        fmt.Fprintf(o.Out, strings.Split(errMsg, ",")[0]+"\n")
                                           ^
make: *** [Makefile:123: golangci-lint] Error 1

please fix the problem if possible

@cnut cnut added the bug Something isn't working label Oct 21, 2024
@ldming ldming assigned yipeng1030 and unassigned ldming Oct 21, 2024
@yipeng1030
Copy link
Contributor

seems 'make kbcli' works now on the main branch.

@github-actions github-actions bot added this to the Release 1.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants