Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support to upgrade addon to 1.0 version #494

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 8.00000% with 46 lines in your changes missing coverage. Please review.

Project coverage is 42.58%. Comparing base (9584c24) to head (8918c2a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/addon/upgrade.go 0.00% 31 Missing ⚠️
pkg/util/util.go 0.00% 9 Missing ⚠️
pkg/cmd/addon/install.go 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
- Coverage   42.66%   42.58%   -0.09%     
==========================================
  Files         172      172              
  Lines       23276    23312      +36     
==========================================
- Hits         9931     9927       -4     
- Misses      12210    12251      +41     
+ Partials     1135     1134       -1     
Flag Coverage Δ
unittests 42.58% <8.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@wangyelei
Copy link
Contributor Author

/approved

@wangyelei wangyelei merged commit 2e1f11f into main Nov 21, 2024
12 checks passed
@wangyelei wangyelei deleted the feature/support_upgrade_addon_to_1.0 branch November 21, 2024 08:33
@github-actions github-actions bot added this to the Release 1.0 milestone Nov 21, 2024
@yipeng1030
Copy link
Contributor

/cherry-pick release-1.0

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/11967452947

github-actions bot pushed a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants