Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add back k8s exec client in kb-agent #8198

Open
cjc7373 opened this issue Sep 24, 2024 · 1 comment · May be fixed by #8243
Open

[Improvement] Add back k8s exec client in kb-agent #8198

cjc7373 opened this issue Sep 24, 2024 · 1 comment · May be fixed by #8243
Assignees
@shanshanying
Labels
kind/enhancement New feature or request

Comments

@cjc7373
Copy link
Contributor

cjc7373 commented Sep 24, 2024

Lorry used to have a k8s exec client, which invokes lorry container through kubectl's exec capabilities. It is useful in local debug, as we often run kubeblocks as a process (with go run commands) instead of building an image and running as a pod.

In kb-agent, this exec client is missing and local debug becomes more complicated. I suggest add back exec client.
@cjc7373 cjc7373 added the kind/enhancement New feature or request label Sep 24, 2024
@cjc7373 cjc7373 linked a pull request Oct 10, 2024 that will close this issue
chore: add port forward when debug #8243
Draft
@cjc7373
Copy link
Contributor Author

cjc7373 commented Oct 10, 2024

Using port forward to achieve the same functionality seems to be better, as it reuses the HTTP client. (So that we don't need to deal with things like escaping quotes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanshanying shanshanying

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add port forward when debug apecloud/kubeblocks
2 participants
@cjc7373 @shanshanying