Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of the render method to ensure compatiblity with Vue 2.0 #4

Closed
LinusBorg opened this issue Aug 19, 2016 · 4 comments
Closed

Comments

@LinusBorg
Copy link
Contributor

Vue 2.0 introduces its own render() function which allows to render vdom elements programatically (like Reactjs).

This will conflict with the render() method of this lib.

to ensure compatibility, a breaking change is required - renaming this method to something else, e.g. renderChart()

@apertureless
Copy link
Owner

Good point. There are also a few other points that needs to get changed to be fully compatible with vue 2

@apertureless apertureless added this to the vue 2 compatible milestone Aug 19, 2016
@LinusBorg
Copy link
Contributor Author

There sure are.

@apertureless
Copy link
Owner

apertureless commented Aug 23, 2016

Working on it in the next branch.
Seems to be working for now, but needs more testing :)

Will look into how to handle multiple releases, so people who are using vue 2.0 can use it, too.

@apertureless
Copy link
Owner

It is now installable over npm i vue-chartjs@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants