UMD module name

[micene09]

Hi, as i see in dist file, the UMD builded code is:

(function webpackUniversalModuleDefinition(root, factory) {
	if(typeof exports === 'object' && typeof module === 'object')
		module.exports = factory();
	else if(typeof define === 'function' && define.amd)
		define("ApexCharts", [], factory);
	else if(typeof exports === 'object')
		exports["ApexCharts"] = factory();
	else
		root["ApexCharts"] = factory();
})(this, function() {

I'm currently using require.js to import this module.
Usually in AMD projects, using the module name in 3rd party dependency give some problems during imports (undefined references), can you make it anonymous as the example below please?

 define([], factory);

[junedchhipa]

I have less knowledge about umd/amd, but you can try editing the webpack configuration here - https://github.com/apexcharts/apexcharts.js/blob/master/webpack.config.js

You can change libraryTarget: 'umd' to libraryTarget: 'amd'
Create a build - and see if it works correctly.
I would accept a PR if this isn't a breaking change.

Or - as an option - I can provide a separate file specifically for amd apexcharts.amd.min.js after testing it.

[micene09]

A separate file should be the safer and fastest solution, if you feel confident too i think you can go and provide a separate amd build (normal + minified).

[junedchhipa]

Cool, I'll try that

[micene09]

According to the webpack's doc, you can set the umdNamedDefine to false.

Just apply this and you don't need to provide a separate build, i tested it and it's working as expected:

(function webpackUniversalModuleDefinition(root, factory) {
	if(typeof exports === 'object' && typeof module === 'object')
		module.exports = factory();
	else if(typeof define === 'function' && define.amd)
		define([], factory); // << anonymous define finally, we got it!
	else if(typeof exports === 'object')
		exports["ApexCharts"] = factory();
	else
		root["ApexCharts"] = factory();
})(this, function() {

[junedchhipa]

Alright, the change will be released in 2.2.4