Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point annotations at last column not visible since 3.54.0 #4734

Closed
Sire opened this issue Sep 30, 2024 · 1 comment · Fixed by TanDuy03/ntanduy-cloud#202 · 4 remaining pull requests
Closed

Point annotations at last column not visible since 3.54.0 #4734

Sire opened this issue Sep 30, 2024 · 1 comment · Fixed by TanDuy03/ntanduy-cloud#202 · 4 remaining pull requests
Labels
bug Something isn't working

Comments

@Sire
Copy link

Sire commented Sep 30, 2024

Adding a point annotation on the last data point worked in v3.53 but doesn't show in v3.54.

My hunch is that is has something to do with all the annotation overflow fixes done in this version.

Is this a bug or am I doing something strange? See reproduced Codepen below.

Steps to Reproduce

  1. Use stock-prices.js sample data
  2. XAxis type = datetime
  3. Labels are dates
  4. Add point annotation on LAST x, y coordinates
  5. Works fine in 3.53
  6. Flip the HTML comments so 3.54 is used and the annotation disappears.

Codepen example

Expected Behavior

Point annotations on the last X,Y coordinates should show, even if clipped.

Actual Behavior

Point annotation disappears.

Screenshots

image

Reproduction Link

Codepen example

@Sire Sire added the bug Something isn't working label Sep 30, 2024
@Sire
Copy link
Author

Sire commented Sep 30, 2024

Holy shit that was fast, thanks! 🥇 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment