Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUESTION - Shouldn't ApexCharts be an external dependency in vite.config.ts? #106

Closed
ggrote opened this issue Jun 21, 2024 · 1 comment
Closed

QUESTION - Shouldn't ApexCharts be an external dependency in vite.config.ts? #106

ggrote opened this issue Jun 21, 2024 · 1 comment

Comments

@ggrote
Copy link
Contributor

ggrote commented Jun 21, 2024

I wanted to change something in ApexChart.js and wondered why the changes are not reflected in my application. Then I saw that the ApexCharts Lib is bundled inside vue3-apexcharts.
So shouldn't this be an external dep? I tried it and it still works. Thx
@ggrote ggrote mentioned this issue Jun 24, 2024
Merged
8 tasks
@ggrote ggrote mentioned this issue Aug 1, 2024
Merged
@ggrote
Copy link
Contributor Author

ggrote commented Aug 26, 2024

Could you please build a new npm package with the external dependency? Thanks in advance!

@ggrote ggrote closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ggrote