Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add more flexibility to ConceptSet #25

Open
Vincent-Maladiere opened this issue Jan 23, 2023 · 1 comment
Open

Feature request: Add more flexibility to ConceptSet #25

Vincent-Maladiere opened this issue Jan 23, 2023 · 1 comment

Comments

@Vincent-Maladiere
Copy link
Collaborator

Description

Currently, adding concept sets is quite hacky:

from eds_scikit.biology import ConceptsSet

protein_blood = ConceptsSet("Protein_Blood_Quantitative")
protein_urine = ConceptsSet("Protein_Urine_Quantitative")
protein = ConceptsSet(
    name="Protein_Quantitative",
    concept_codes=protein_blood.concept_codes + protein_urine.concept_codes,
)

It would be handier to have the following:

protein = protein_blood + protein_urine

The concept_name could be generic like "addition_1" since it doesn't seem to be used except in the bioclean table.

We would need to add to ConceptSet:

  • __add__
  • __sub__
  • __eq__
@Thomzoy
Copy link
Collaborator

Thomzoy commented Feb 3, 2023

Yep good idea !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants