Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Termination improvement: Support for newline character #176

Open
lbasseto opened this issue Dec 14, 2022 · 1 comment
Open

Termination improvement: Support for newline character #176

lbasseto opened this issue Dec 14, 2022 · 1 comment

Comments

@lbasseto
Copy link

Hi,

Would you consider adding the newline character "\n" to the list of terminations (in edsnlp.pipelines.terminations)?

In a note like this:


pas de toux
NOVATREX

NOVATREX would for example qualify as a negation because the line above contains "pas". I have see this list structure with "\n" used as a separator and no punctuation a few times.

Also: Great work on the package! Thank you :)

@Thomzoy
Copy link
Collaborator

Thomzoy commented Dec 19, 2022

Hi Louis !

Thanks for bringing this up. In fact, we were discussing about another issue that is closely related to your problem.
We're going to add an option to the sentences pipeline, where a \n followed by an uppercase character would constitute an end of sentence. This would also solve you problem since the negation pipeline only looks for cues inside each entity's sentence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants