Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: IAM system #191

Open
percevalw opened this issue Feb 21, 2023 · 0 comments
Open

Feature request: IAM system #191

percevalw opened this issue Feb 21, 2023 · 0 comments

Comments

@percevalw
Copy link
Member

Feature type

After discussing with @scossin, it would be a nice feature to be able to use the IAM system with EDS-NLP. Since this library already ships with a spaCy connector, a first step would be to create a documentation page here referencing the project and demonstrating it on an example similar to the Matcher to inform users.

To make this component compatible with edsnlp, the only things missing are:

  • the ability to add the detected entities to the Doc.ents and to assign them a label, either fixed or dynamic according to the kb_id of the retrieved entity
  • make it available via spaCy's entry points (spacy_factories)

We could also add the IAM system as a matcher (https://github.com/aphp/edsnlp/tree/master/edsnlp/matchers), but this would require splitting it into multiple parts to remain modular (add spellwise to normalizers, trie + simstring / levenshtein / ..., make it accept a dict of patterns, etc) so let's keep it simple for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant