Split methods

Author: dunglas

src/Metadata/YamlExtractor.php

@@ -68,62 +68,72 @@ public function getResources(): array
                 throw new InvalidArgumentException(sprintf('"resources" setting is expected to be null or an array, %s given in "%s".', gettype($resourcesYaml), $path));
             }
 
-            foreach ($resourcesYaml as $resourceName => $resourceYaml) {
-                if (null === $resourceYaml) {
-                    $this->resources[$resourceName] = null;
-
-                    continue;
-                }
-
-                if (!is_array($resourceYaml)) {
-                    throw new InvalidArgumentException(sprintf('"%s" setting is expected to be null or an array, %s given in "%s".', $resourceName, gettype($resourceYaml), $path));
-                }
-
-                $this->resources[$resourceName] = [
-                    'shortName' => $resourceYaml['shortName'] ?? null,
-                    'description' => $resourceYaml['description'] ?? null,
-                    'iri' => $resourceYaml['iri'] ?? null,
-                    'itemOperations' => $resourceYaml['itemOperations'] ?? null,
-                    'collectionOperations' => $resourceYaml['collectionOperations'] ?? null,
-                    'attributes' => $resourceYaml['attributes'] ?? null,
-                ];
-
-                if (!isset($resourceYaml['properties'])) {
-                    $this->resources[$resourceName]['properties'] = null;
-
-                    continue;
-                }
-
-                if (!is_array($resourceYaml['properties'])) {
-                    throw new InvalidArgumentException(sprintf('"properties" setting is expected to be null or an array, %s given in "%s".', gettype($resourceYaml['properties']), $path));
-                }
-
-                foreach ($resourceYaml['properties'] as $propertyName => $propertyValues) {
-                    if (null === $propertyValues) {
-                        $this->resources[$resourceName]['properties'][$propertyName] = null;
-
-                        continue;
-                    }
-
-                    if (!is_array($propertyValues)) {
-                        throw new InvalidArgumentException(sprintf('"%s" setting is expected to be null or an array, %s given in "%s".', $propertyName, gettype($propertyValues), $path));
-                    }
-
-                    $this->resources[$resourceName]['properties'][$propertyName] = [
-                        'description' => isset($propertyValues['description']) && is_scalar($propertyValues['description']) ? $propertyValues['description'] : null,
-                        'readable' => isset($propertyValues['readable']) && is_bool($propertyValues['readable']) ? $propertyValues['readable'] : null,
-                        'writable' => isset($propertyValues['writable']) && is_bool($propertyValues['writable']) ? $propertyValues['writable'] : null,
-                        'readableLink' => isset($propertyValues['readableLink']) && is_bool($propertyValues['readableLink']) ? $propertyValues['readableLink'] : null,
-                        'writableLink' => isset($propertyValues['writableLink']) && is_bool($propertyValues['writableLink']) ? $propertyValues['writableLink'] : null,
-                        'required' => isset($propertyValues['required']) && is_bool($propertyValues['required']) ? $propertyValues['required'] : null,
-                        'identifier' => isset($propertyValues['identifier']) && is_bool($propertyValues['identifier']) ? $propertyValues['identifier'] : null,
-                        'iri' => isset($propertyValues['iri']) && is_scalar($propertyValues['iri']) ? $propertyValues['iri'] : null,
-                        'attributes' => $propertyValues['attributes'] ?? null,
-                    ];
-                }
-            }
+            $this->extractResourcesFromYaml($resourcesYaml, $path);
         }
 
         return $this->resources;
     }
+
+    private function extractResourcesFromYaml(array $resourcesYaml, string $path)
+    {
+        foreach ($resourcesYaml as $resourceName => $resourceYaml) {
+            if (null === $resourceYaml) {
+                $this->resources[$resourceName] = null;
+
+                continue;
+            }
+
+            if (!is_array($resourceYaml)) {
+                throw new InvalidArgumentException(sprintf('"%s" setting is expected to be null or an array, %s given in "%s".', $resourceName, gettype($resourceYaml), $path));
+            }
+
+            $this->resources[$resourceName] = [
+                'shortName' => $resourceYaml['shortName'] ?? null,
+                'description' => $resourceYaml['description'] ?? null,
+                'iri' => $resourceYaml['iri'] ?? null,
+                'itemOperations' => $resourceYaml['itemOperations'] ?? null,
+                'collectionOperations' => $resourceYaml['collectionOperations'] ?? null,
+                'attributes' => $resourceYaml['attributes'] ?? null,
+            ];
+
+            if (!isset($resourceYaml['properties'])) {
+                $this->resources[$resourceName]['properties'] = null;
+
+                continue;
+            }
+
+            if (!is_array($resourceYaml['properties'])) {
+                throw new InvalidArgumentException(sprintf('"properties" setting is expected to be null or an array, %s given in "%s".', gettype($resourceYaml['properties']), $path));
+            }
+
+            $this->extractPropertiesFromYaml($resourceYaml, $resourceName, $path);
+        }
+    }
+
+    private function extractPropertiesFromYaml(array $resourceYaml, string $resourceName, $path)
+    {
+        foreach ($resourceYaml['properties'] as $propertyName => $propertyValues) {
+            if (null === $propertyValues) {
+                $this->resources[$resourceName]['properties'][$propertyName] = null;
+
+                continue;
+            }
+
+            if (!is_array($propertyValues)) {
+                throw new InvalidArgumentException(sprintf('"%s" setting is expected to be null or an array, %s given in "%s".', $propertyName, gettype($propertyValues), $path));
+            }
+
+            $this->resources[$resourceName]['properties'][$propertyName] = [
+                'description' => isset($propertyValues['description']) && is_scalar($propertyValues['description']) ? $propertyValues['description'] : null,
+                'readable' => isset($propertyValues['readable']) && is_bool($propertyValues['readable']) ? $propertyValues['readable'] : null,
+                'writable' => isset($propertyValues['writable']) && is_bool($propertyValues['writable']) ? $propertyValues['writable'] : null,
+                'readableLink' => isset($propertyValues['readableLink']) && is_bool($propertyValues['readableLink']) ? $propertyValues['readableLink'] : null,
+                'writableLink' => isset($propertyValues['writableLink']) && is_bool($propertyValues['writableLink']) ? $propertyValues['writableLink'] : null,
+                'required' => isset($propertyValues['required']) && is_bool($propertyValues['required']) ? $propertyValues['required'] : null,
+                'identifier' => isset($propertyValues['identifier']) && is_bool($propertyValues['identifier']) ? $propertyValues['identifier'] : null,
+                'iri' => isset($propertyValues['iri']) && is_scalar($propertyValues['iri']) ? $propertyValues['iri'] : null,
+                'attributes' => $propertyValues['attributes'] ?? null,
+            ];
+        }
+    }
 }