fix(laravel): Eloquent PropertyAccessor (#6536)

* fix(laravel): null values handling in Eloquent PropertyAccessor

* add test

Author: dunglas

src/Laravel/Eloquent/PropertyAccess/PropertyAccessor.php

@@ -13,7 +13,7 @@
 
 namespace ApiPlatform\Laravel\Eloquent\PropertyAccess;
 
-use Illuminate\Database\Eloquent\Relations\HasMany;
+use Illuminate\Database\Eloquent\Model;
 use Symfony\Component\PropertyAccess\PropertyAccess;
 use Symfony\Component\PropertyAccess\PropertyAccessorInterface;
 use Symfony\Component\PropertyAccess\PropertyPathInterface;
@@ -36,6 +36,12 @@ public function __construct(
      */
     public function setValue(object|array &$objectOrArray, string|PropertyPathInterface $propertyPath, mixed $value): void
     {
+        if ($objectOrArray instanceof Model) {
+            $objectOrArray->{$propertyPath} = $value;
+
+            return;
+        }
+
         $this->inner->setValue($objectOrArray, $propertyPath, $value);
     }
 
@@ -44,20 +50,22 @@ public function setValue(object|array &$objectOrArray, string|PropertyPathInterf
      */
     public function getValue(object|array $objectOrArray, string|PropertyPathInterface $propertyPath): mixed
     {
-        $value = $this->inner->getValue($objectOrArray, $propertyPath);
-
-        if ($value instanceof HasMany) {
+        if ($objectOrArray instanceof Model) {
             return $objectOrArray->{$propertyPath};
         }
 
-        return $value;
+        return $this->inner->getValue($objectOrArray, $propertyPath);
     }
 
     /**
      * @param array<mixed, mixed>|object $objectOrArray
      */
     public function isWritable(object|array $objectOrArray, string|PropertyPathInterface $propertyPath): bool
     {
+        if ($objectOrArray instanceof Model) {
+            return true;
+        }
+
         return $this->inner->isWritable($objectOrArray, $propertyPath);
     }
 
@@ -66,6 +74,10 @@ public function isWritable(object|array $objectOrArray, string|PropertyPathInter
      */
     public function isReadable(object|array $objectOrArray, string|PropertyPathInterface $propertyPath): bool
     {
+        if ($objectOrArray instanceof Model) {
+            return true;
+        }
+
         return $this->inner->isReadable($objectOrArray, $propertyPath);
     }
 }

src/Laravel/Tests/JsonApiTest.php

@@ -69,8 +69,19 @@ public function testCreateBook(): void
             '/api/books',
             [
                 'data' => [
-                    'attributes' => ['name' => 'Don Quichotte', 'isbn' => fake()->isbn13(), 'publicationDate' => fake()->date()],
-                    'relationships' => ['author' => ['data' => ['id' => $this->getIriFromResource($author), 'type' => 'Author']]],
+                    'attributes' => [
+                        'name' => 'Don Quichotte',
+                        'isbn' => fake()->isbn13(),
+                        'publicationDate' => fake()->optional()->date(),
+                    ],
+                    'relationships' => [
+                        'author' => [
+                            'data' => [
+                                'id' => $this->getIriFromResource($author),
+                                'type' => 'Author',
+                            ],
+                        ],
+                    ],
                 ],
             ],
             [

src/Laravel/Tests/JsonLdTest.php

@@ -63,7 +63,7 @@ public function testCreateBook(): void
                 'name' => 'Don Quichotte',
                 'author' => $this->getIriFromResource($author),
                 'isbn' => fake()->isbn13(),
-                'publicationDate' => fake()->date(),
+                'publicationDate' => fake()->optional()->date(),
             ],
             [
                 'accept' => 'application/ld+json',

src/Laravel/workbench/database/factories/BookFactory.php

@@ -36,7 +36,7 @@ public function definition(): array
             'id' => (string) new Ulid(),
             'author_id' => AuthorFactory::new(),
             'isbn' => fake()->isbn13(),
-            'publication_date' => fake()->date(),
+            'publication_date' => fake()->optional()->date(),
         ];
     }
 }

src/Laravel/workbench/database/migrations/2023_07_15_231244_create_book_table.php

@@ -31,7 +31,7 @@ public function up(): void
             $table->ulid('id')->primary();
             $table->string('name');
             $table->string('isbn');
-            $table->date('publication_date');
+            $table->date('publication_date')->nullable();
             $table->integer('author_id')->unsigned();
             $table->foreign('author_id')->references('id')->on('authors');
             $table->timestamps();