Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add a where filter. #1832

Closed
Simperfit opened this issue Apr 9, 2018 · 6 comments
Closed

[RFC] Add a where filter. #1832

Simperfit opened this issue Apr 9, 2018 · 6 comments
Assignees

Comments

@Simperfit
Copy link
Contributor

Simperfit commented Apr 9, 2018

@dunglas on api-platform/api-platform#577:

The best would be to have something like this: https://loopback.io/doc/en/lb2/Where-filter.html
A or filter on steroid!

This will give the ability to filter everything like a dql or a sql where.

@Simperfit
Copy link
Contributor Author

is this really needed ? I mean we already have alots of filter covering alot of the uses cases of the where filter. Could we maybe reuse the filter we already have with this one like a proxy ? or do we want to implement everything and then deprecate the other filter ?

@sstok
Copy link

sstok commented Apr 13, 2018

I think this can be easily solved using the solution I discussed in #991 (the Query Generating that is, the current SearchCondition format is getting more and more troubling) 😛 there are some issues reported in the RollerworksSearch repository. But I haven't had time to use the API-Platform yet, so any suggestions on how to do this better are welcome (including a completely new approach) for search processing with the API-Platform)). rollerworks/search#174

I need some good key points to work-on because I don't have a fully functioning project atm and guessing hasn't brought my anything good in the past 🤦‍♂️

@teohhanhui
Copy link
Contributor

I'm definitely -1 for this. This opens a whole can of worms.

@soyuka
Copy link
Member

soyuka commented Apr 19, 2018

Also -1

@Simperfit
Copy link
Contributor Author

@sstok I will try to look at it when I can ;).

Closing as this seems to be not needed :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants